Fixed idempotency bug relating to MODULES-1984

diff --git a/manifests/linux/redhat.pp b/manifests/linux/redhat.pp
index 9a33abbd367a0d21fbde2fbdf2c937ba071c7da5..36571bba93e6eb144cf93d479b22603c27bcef25 100644 (file)
--- a/manifests/linux/redhat.pp
+++ b/manifests/linux/redhat.pp
@@ -42,8 +42,12 @@ class firewall::linux::redhat (
   if ($::operatingsystem != 'Amazon')
   and (($::operatingsystem != 'Fedora' and versioncmp($::operatingsystemrelease, '7.0') >= 0)
   or  ($::operatingsystem == 'Fedora' and versioncmp($::operatingsystemrelease, '15') >= 0)) {
-    exec { '/usr/bin/systemctl daemon-reload':
-      require   => Package[$package_name],
+    if $ensure == 'running' {
+      exec { '/usr/bin/systemctl daemon-reload':
+        require   => Package[$package_name],
+        before    => Service[$service_name],
+        unless    => '/usr/bin/systemctl is-active iptables'
+      }
     }
   }