]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Log which service is down
authorEric Harney <eharney@redhat.com>
Mon, 27 Jul 2015 17:24:36 +0000 (13:24 -0400)
committerEric Harney <eharney@redhat.com>
Tue, 28 Jul 2015 13:12:16 +0000 (09:12 -0400)
This changes the message "Manager for service cinder-volume
is reporting problems..." to
"Manager for service cinder-volume myhost@backend1 is
reporting problems..."

This makes it more clear in the log file which backend this
message is referring to.

Change-Id: I62172080084a01c0324ffb6ab8a0e4af2b47fb85

cinder/service.py

index 595e6da4ceecf2659f4b7e79db70501ed3072258..95010fa05ac6a6583dbad5a57c643f04a2eb4e77 100644 (file)
@@ -293,9 +293,11 @@ class Service(service.Service):
         if not self.manager.is_working():
             # NOTE(dulek): If manager reports a problem we're not sending
             # heartbeats - to indicate that service is actually down.
-            LOG.error(_LE('Manager for service %s is reporting problems, skip '
-                          'sending heartbeat. Service will appear "down".'),
-                      self.binary)
+            LOG.error(_LE('Manager for service %(binary)s %(host)s is '
+                          'reporting problems, not sending heartbeat. '
+                          'Service will appear "down".'),
+                      {'binary': self.binary,
+                       'host': self.host})
             return
 
         ctxt = context.get_admin_context()