]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Merge "Deprecate new= argument from create_connection"
authorJenkins <jenkins@review.openstack.org>
Fri, 6 Nov 2015 17:31:47 +0000 (17:31 +0000)
committerGerrit Code Review <review@openstack.org>
Fri, 6 Nov 2015 17:31:47 +0000 (17:31 +0000)
1  2 
neutron/common/rpc.py
neutron/plugins/brocade/NeutronPlugin.py
neutron/plugins/ml2/plugin.py

index 6d37c28ba06a4c472baf21f58569c13385c5432b,f4b7475f09658e0f1260f673b26144954e8de3a2..beef015ad81065aa1a81d076b0078dcf70991c86
@@@ -220,8 -221,9 +221,9 @@@ class VoidConnection(object)
  
  
  # functions
+ @removals.removed_kwarg('new')
  def create_connection(new=True):
 -    # NOTE(salv-orlando): This is a clever interpreation of the factory design
 +    # NOTE(salv-orlando): This is a clever interpretation of the factory design
      # patter aimed at preventing plugins from initializing RPC servers upon
      # initialization when they are running in the REST over HTTP API server.
      # The educated reader will perfectly be able that this a fairly dirty hack
index a2ee1de6aace8b4cb15ba2935f96e8053a369706,622d012bfc44ca10987816d76b3c7589463de554..5b3569266c734be8a162a828e01be4bd6fbccb42
@@@ -188,9 -188,8 +188,9 @@@ class Ml2Plugin(db_base_plugin_v2.Neutr
          """Start the RPC loop to let the plugin communicate with agents."""
          self._setup_rpc()
          self.topic = topics.PLUGIN
-         self.conn = n_rpc.create_connection(new=True)
+         self.conn = n_rpc.create_connection()
          self.conn.create_consumer(self.topic, self.endpoints, fanout=False)
 +        # process state reports despite dedicated rpc workers
          self.conn.create_consumer(topics.REPORTS,
                                    [agents_db.AgentExtRpcCallback()],
                                    fanout=False)