]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
mock time.sleep in Broadcom unit test
authorTom Barron <tpb@dyncloud.net>
Wed, 3 Feb 2016 22:14:23 +0000 (17:14 -0500)
committerTom Barron <tpb@dyncloud.net>
Wed, 3 Feb 2016 22:25:27 +0000 (17:25 -0500)
TestBrcdHttpFCZoneClient.test_post_zone_data() invokes
BrcdHTTPFCZoneClient.post_zone_data(), which in turn
has a loop around its connect() method inside which there
is a sleep().  Without time.sleep() mocked out, the test
runs 7s on my laptop.

This change mocks out time.sleep() in the test so that
it now runs in .6s.

Change-Id: Ib4c3a12b048a68d2c2db722c089eb04dd7d8c8ef

cinder/tests/unit/zonemanager/test_brcd_http_fc_zone_client.py

index 67872f03b82f1fe7438c9d8e829dc07f4c5d13d9..739e377b5a710c83c04ef7622452036378ae70db 100644 (file)
@@ -15,6 +15,8 @@
 #
 
 """Unit tests for brcd fc zone client http(s)."""
+import time
+
 from mock import patch
 
 from cinder import exception
@@ -483,8 +485,9 @@ class TestBrcdHttpFCZoneClient(client.BrcdHTTPFCZoneClient, test.TestCase):
         self.assertRaises(exception.BrocadeZoningHttpException,
                           self.delete_zones, delete_zones_info, False)
 
+    @patch.object(time, 'sleep')
     @patch.object(client.BrcdHTTPFCZoneClient, 'connect')
-    def test_post_zone_data(self, connect_mock):
+    def test_post_zone_data(self, connect_mock, sleep_mock):
         connect_mock.return_value = zone_post_page
         self.assertEqual(
             ("-1", "Name too long"), self.post_zone_data(zone_string_to_post))