]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Enable assignment-from-no-return pylint check
authorAngus Lees <gus@inodes.org>
Tue, 21 Oct 2014 04:20:28 +0000 (15:20 +1100)
committerAngus Lees <gus@inodes.org>
Tue, 21 Oct 2014 04:20:28 +0000 (15:20 +1100)
The @versioning.versioned decorator used (only) in
plugins.vmware.nsxlib.router completely confuses this check, so add a
file-local pylint disable.

Change-Id: I2a79a643a982f49faaf22b88764cb170ef89ce21

.pylintrc
neutron/plugins/vmware/nsxlib/router.py

index c738c547c1dc78f5b756120906d133c9aa2a534d..713494c1035198f6c1628bea397e0251d6f220d3 100644 (file)
--- a/.pylintrc
+++ b/.pylintrc
@@ -19,7 +19,6 @@ disable=
  locally-disabled,
 # "E" Error for important programming issues (likely bugs)
  access-member-before-definition,
- assignment-from-no-return,
  bad-except-order,
  bad-super-call,
  maybe-no-member,
index 254b4b6a5177f1a70a87be95ce509bbcf031a3be..2ef5245ab55e3e3b4ad7fe47afd6386f4f42bafa 100644 (file)
@@ -26,6 +26,10 @@ from neutron.plugins.vmware import nsxlib
 from neutron.plugins.vmware.nsxlib import switch
 from neutron.plugins.vmware.nsxlib import versioning
 
+# @versioning.versioned decorator makes the apparent function body
+# totally unrelated to the real function.  This confuses pylint :(
+# pylint: disable=assignment-from-no-return
+
 HTTP_GET = "GET"
 HTTP_POST = "POST"
 HTTP_DELETE = "DELETE"