]> review.fuel-infra Code Review - openstack-build/heat-build.git/commitdiff
Update install_venv_common from oslo-incubator
authorMark McLoughlin <markmc@redhat.com>
Mon, 13 May 2013 21:51:06 +0000 (22:51 +0100)
committerMark McLoughlin <markmc@redhat.com>
Mon, 13 May 2013 21:51:49 +0000 (22:51 +0100)
Just some python3 compat work.

Change-Id: I835765d45a861d0bcf9b348f0649c6c9ef5a1992

tools/install_venv_common.py

index 0401a958f9f87ba56ebbdefc2d55c0d803d24337..914fcf17ecfea95fd4fb508fb69209e465f884b2 100644 (file)
@@ -24,6 +24,8 @@ environment, it should be kept strictly compatible with Python 2.6.
 Synced in from openstack-common
 """
 
+from __future__ import print_function
+
 import optparse
 import os
 import subprocess
@@ -42,7 +44,7 @@ class InstallVenv(object):
         self.project = project
 
     def die(self, message, *args):
-        print >> sys.stderr, message % args
+        print(message % args, file=sys.stderr)
         sys.exit(1)
 
     def check_python_version(self):
@@ -89,20 +91,20 @@ class InstallVenv(object):
         virtual environment.
         """
         if not os.path.isdir(self.venv):
-            print 'Creating venv...',
+            print('Creating venv...', end=' ')
             if no_site_packages:
                 self.run_command(['virtualenv', '-q', '--no-site-packages',
                                  self.venv])
             else:
                 self.run_command(['virtualenv', '-q', self.venv])
-            print 'done.'
-            print 'Installing pip in venv...',
+            print('done.')
+            print('Installing pip in venv...', end=' ')
             if not self.run_command(['tools/with_venv.sh', 'easy_install',
                                     'pip>1.0']).strip():
                 self.die("Failed to install pip.")
-            print 'done.'
+            print('done.')
         else:
-            print "venv already exists..."
+            print("venv already exists...")
             pass
 
     def pip_install(self, *args):
@@ -111,7 +113,7 @@ class InstallVenv(object):
                          redirect_output=False)
 
     def install_dependencies(self):
-        print 'Installing dependencies with pip (this can take a while)...'
+        print('Installing dependencies with pip (this can take a while)...')
 
         # First things first, make sure our venv has the latest pip and
         # distribute.
@@ -153,12 +155,12 @@ class Distro(InstallVenv):
             return
 
         if self.check_cmd('easy_install'):
-            print 'Installing virtualenv via easy_install...',
+            print('Installing virtualenv via easy_install...', end=' ')
             if self.run_command(['easy_install', 'virtualenv']):
-                print 'Succeeded'
+                print('Succeeded')
                 return
             else:
-                print 'Failed'
+                print('Failed')
 
         self.die('ERROR: virtualenv not found.\n\n%s development'
                  ' requires virtualenv, please install it using your'