]> review.fuel-infra Code Review - openstack-build/heat-build.git/commitdiff
heat engine : watchrule save state when actions undefined
authorSteven Hardy <shardy@redhat.com>
Fri, 18 Jan 2013 17:34:12 +0000 (17:34 +0000)
committerSteven Hardy <shardy@redhat.com>
Mon, 21 Jan 2013 20:24:20 +0000 (20:24 +0000)
We should save WatchRule state transitions, even if an action
for that state has not been defined in the template.

Change-Id: Iadca203d03b2c2a2a186a4e9574687d8f30ab080
Signed-off-by: Steven Hardy <shardy@redhat.com>
heat/engine/watchrule.py

index da33f4b5e6ecffe28b4dc803aca177f342411c04..a5aa5a74dcc7d990149272675d5b4d4c122c9cd1 100644 (file)
@@ -220,8 +220,8 @@ class WatchRule(object):
         new_state = self.get_alarm_state()
 
         if new_state != self.state:
-            if self.rule_action(new_state):
-                self.state = new_state
+            action = self.rule_action(new_state)
+            self.state = new_state
 
         self.last_evaluated = self.now
         self.store()