]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Fix negative unit test for sec group rules
authorSalvatore Orlando <salv.orlando@gmail.com>
Mon, 13 Jan 2014 11:33:40 +0000 (03:33 -0800)
committerSalvatore Orlando <salv.orlando@gmail.com>
Tue, 14 Jan 2014 23:24:50 +0000 (15:24 -0800)
Ensure the test fails because the security group
rule could not be created, and not because the security
group was deleted before creating the rule.

Closes-Bug: #1268561

Change-Id: Ib2ea8c4507862d7bb343ce5181cf018b3cdf4b73

neutron/tests/unit/test_extension_security_group.py

index eec1e3d2c32c6102ddfc9e731e3032f9ec5b5791..16fe3902a340f597e238f2b43e77bffbf1846823 100644 (file)
@@ -738,9 +738,11 @@ class TestSecurityGroups(SecurityGroupDBTestCase):
                      'port_range_max': '22',
                      'tenant_id': "bad_tenant"}}
 
-        res = self._create_security_group_rule(self.fmt, rule)
-        self.deserialize(self.fmt, res)
-        self.assertEqual(res.status_int, webob.exc.HTTPNotFound.code)
+            res = self._create_security_group_rule(self.fmt, rule,
+                                                   tenant_id='bad_tenant',
+                                                   set_context=True)
+            self.deserialize(self.fmt, res)
+            self.assertEqual(res.status_int, webob.exc.HTTPNotFound.code)
 
     def test_create_security_group_rule_bad_tenant_remote_group_id(self):
         with self.security_group() as sg: