]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
tests: don't allow oslo.config to autodiscover config files
authorIhar Hrachyshka <ihrachys@redhat.com>
Fri, 10 Apr 2015 09:29:56 +0000 (11:29 +0200)
committerabregman <abregman@redhat.com>
Mon, 8 Jun 2015 14:59:59 +0000 (14:59 +0000)
oslo.config makes attempts to autodiscover configuration files using
find_config_files() helper. If e.g. /etc/neutron/neutron.conf exists,
and is not readable, the following test failure can be experienced:

oslo_config.cfg.ConfigFilesPermissionDeniedError: Failed to open some
config files: /etc/neutron/neutron.conf

Unit tests must not rely on any external state of the system and run
successfully no matter whether neutron is actually installed on the
system, or not.

Closes-Bug: #1442543
Change-Id: Ic90d8c40b2072fdda152703b84081719936b5f4e
(cherry picked from commit 54fc39308277d4aedc3e399286714d719ecacfbb)

neutron/tests/base.py

index e6e3f44cf92f76da05d5baa46778c61b16ca0714..b3e4bc6b17eadc9d8a8576cf74549cfd8d209b56 100644 (file)
@@ -249,6 +249,10 @@ class BaseTestCase(DietTestCase):
             'neutron.common.exceptions.NeutronException.use_fatal_exceptions',
             fake_use_fatal_exceptions))
 
+        self.useFixture(fixtures.MonkeyPatch(
+            'oslo_config.cfg.find_config_files',
+            lambda project=None, prog=None, extension=None: []))
+
         self.setup_rpc_mocks()
         self.setup_config()