Port scheduler host manager to Python 3

* Rewrite ReadOnlyDict using collections.Mapping: collections.Mapping
  has no method to modify the dictionary and is available on Python 2
  and Python 3. Add also a __repr__() method to ease debug. Remove
  ReadOnlyDict.update() method: a read-only dictionary must not be
  modifiable.
* test_host_manager.py: sort dictionaries using a key function to
  have a reliable order for the list of dictionaries. On Python 3,
  the hash function is now randomized.
* tox.ini. add cinder/tests/unit/scheduler/ tests to Python 3.4

Blueprint cinder-python3
Change-Id: I34d98d6a75fef907251719f0d46b025d8e8b2b65

diff --git a/cinder/scheduler/host_manager.py b/cinder/scheduler/host_manager.py
index 45077e5e946e98e3878f6819a90bc219a5c0dc8c..9cf70739bdbf8ac994f9ed1cfd280e24fd8407ae 100644 (file)
--- a/cinder/scheduler/host_manager.py
+++ b/cinder/scheduler/host_manager.py
@@ -17,7 +17,7 @@
 Manage hosts in the current zone.
 """
 
-import UserDict
+import collections
 
 from oslo_config import cfg
 from oslo_log import log as logging
@@ -57,36 +57,25 @@ CONF.import_opt('max_over_subscription_ratio', 'cinder.volume.driver')
 LOG = logging.getLogger(__name__)
 
 
-class ReadOnlyDict(UserDict.IterableUserDict):
+class ReadOnlyDict(collections.Mapping):
     """A read-only dict."""
     def __init__(self, source=None):
-        self.data = {}
-        self.update(source)
-
-    def __setitem__(self, key, item):
-        raise TypeError
-
-    def __delitem__(self, key):
-        raise TypeError
+        if source is not None:
+            self.data = dict(source)
+        else:
+            self.data = {}
 
-    def clear(self):
-        raise TypeError
+    def __getitem__(self, key):
+        return self.data[key]
 
-    def pop(self, key, *args):
-        raise TypeError
+    def __iter__(self):
+        return iter(self.data)
 
-    def popitem(self):
-        raise TypeError
+    def __len__(self):
+        return len(self.data)
 
-    def update(self, source=None):
-        if source is None:
-            return
-        elif isinstance(source, UserDict.UserDict):
-            self.data = source.data
-        elif isinstance(source, type({})):
-            self.data = source
-        else:
-            raise TypeError
+    def __repr__(self):
+        return '%s(%r)' % (self.__class__.__name__, self.data)
 
 
 class HostState(object):

diff --git a/cinder/tests/unit/scheduler/test_host_manager.py b/cinder/tests/unit/scheduler/test_host_manager.py
index 2f27aced0f7c644fb942bc1dcf4a773d09bcbbbc..6d89f7ee21f51c87cfa18a65ed5e5164ab5860fb 100644 (file)
--- a/cinder/tests/unit/scheduler/test_host_manager.py
+++ b/cinder/tests/unit/scheduler/test_host_manager.py
@@ -389,8 +389,13 @@ class HostManagerTestCase(test.TestCase):
                         'provisioned_capacity_gb': 9300},
                 }
             ]
+
+            def sort_func(data):
+                return data['name']
+
             self.assertEqual(len(expected), len(res))
-            self.assertEqual(sorted(expected), sorted(res))
+            self.assertEqual(sorted(expected, key=sort_func),
+                             sorted(res, key=sort_func))
 
 
 class HostStateTestCase(test.TestCase):

diff --git a/tox.ini b/tox.ini
index 720d144927568e4347fa36cb6f318573e5caf6aa..378af8501788a99e32d88e49ae0706b4868d041c 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -31,6 +31,17 @@ commands =
   python -m testtools.run \
     cinder.tests.unit.image.test_glance \
     cinder.tests.unit.keymgr.test_mock_key_mgr \
+    cinder.tests.unit.scheduler.test_allocated_capacity_weigher \
+    cinder.tests.unit.scheduler.test_capacity_weigher \
+    cinder.tests.unit.scheduler.test_chance_weigher \
+    cinder.tests.unit.scheduler.test_filter_scheduler \
+    cinder.tests.unit.scheduler.test_goodness_weigher \
+    cinder.tests.unit.scheduler.test_host_filters \
+    cinder.tests.unit.scheduler.test_host_manager \
+    cinder.tests.unit.scheduler.test_rpcapi \
+    cinder.tests.unit.scheduler.test_scheduler \
+    cinder.tests.unit.scheduler.test_scheduler_options \
+    cinder.tests.unit.scheduler.test_volume_number_weigher \
     cinder.tests.unit.targets.test_base_iscsi_driver \
     cinder.tests.unit.targets.test_cxt_driver \
     cinder.tests.unit.targets.test_iser_driver \