]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Fetch all pages when listing NVP Nat Rules
authorSalvatore Orlando <salv.orlando@gmail.com>
Tue, 26 Feb 2013 14:19:40 +0000 (15:19 +0100)
committerSalvatore Orlando <salv.orlando@gmail.com>
Tue, 26 Feb 2013 14:19:40 +0000 (15:19 +0100)
Bug 1133318

Change-Id: I24e9943b4771c4f2b941c229ba1c300dfbf7e331

quantum/plugins/nicira/nicira_nvp_plugin/nvplib.py

index 72fa0557565a21dce78a560aac567047f03fdc17..0bbabd5984a3e6a5361a288f6354be7e1b2ac895 100644 (file)
@@ -1239,7 +1239,7 @@ def query_nat_rules(cluster, router_id, fields="*", filters=None):
     uri = _build_uri_path(LROUTERNAT_RESOURCE, parent_resource_id=router_id,
                           fields=fields, filters=filters)
     try:
-        resp = do_single_request(HTTP_GET, uri, cluster=cluster)
+        result = get_all_query_pages(uri, cluster)
     except NvpApiClient.ResourceNotFound:
         LOG.exception(_("NVP Logical Router '%s' not found"), router_id)
         raise
@@ -1247,8 +1247,7 @@ def query_nat_rules(cluster, router_id, fields="*", filters=None):
         LOG.exception(_("An error occured while retrieving NAT rules for "
                         "NVP logical router '%s'"), router_id)
         raise
-    res = json.loads(resp)
-    return res["results"]
+    return result
 
 
 # NOTE(salvatore-orlando): The following FIXME applies in general to