]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Add note that some checks are disabled on purpose
authorChristian Berendt <berendt@b1-systems.de>
Thu, 31 Jul 2014 08:17:54 +0000 (10:17 +0200)
committerChristian Berendt <berendt@b1-systems.de>
Fri, 1 Aug 2014 11:08:47 +0000 (13:08 +0200)
Change-Id: I9a2daf57a8bb73e292d99f5177c310d75061cc13

tox.ini

diff --git a/tox.ini b/tox.ini
index 07c7e66bf1d323bbfff11d7ce3f286413ef5aa72..87feb47c141c037bd08697ac7d36e02035551f8a 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -49,9 +49,29 @@ commands = {toxinidir}/tools/config/generate_sample.sh -b . -p cinder -o etc/cin
 commands = {posargs}
 
 [flake8]
-# Due to hacking 0.9.2 following checking are ignored on purpose for now
-#  E111,E112,E113,E121,E122,E123,E126,E128,E251,E265
-#  E713,F403,F841,H302,H305,H307,H402,H405,H803,H904
+# Following checks are ignored on purpose.
+#
+# E251 unexpected spaces around keyword / parameter equals
+# reason: no improvement in readability
+#
+# E265 block comment should start with '# '
+# reason: no improvement in readability
+#
+# H402 one line docstring needs punctuation
+# reason: removed in hacking (https://review.openstack.org/#/c/101497/)
+#
+# H803 git commit title should not end with period
+# reason: removed in hacking (https://review.openstack.org/#/c/101498/)
+#
+# H904 wrap long lines in parentheses instead of a backslash
+# reason: removed in hacking (https://review.openstack.org/#/c/101701/)
+#
+# Due to the upgrade to hacking 0.9.2 the following checking are
+# ignored on purpose for the moment and should be re-enabled.
+#
+# F841,H302,H305,H307,H405
+
+
 ignore = E251,E265,E711,E712,E713,F402,F841,H104,H302,H305,H307,H402,H405,H803,H904
 builtins = _
 exclude = .git,.venv,.tox,dist,tools,doc,common,*egg,build