Install required_packages before 'apt-get update'

This is necessary when required_packages contains GPG keys that are used for
authenticating other packages. Tested with package ubuntu-cloud-keyring which
is included in Ubuntu main and used by the Ubuntu Cloud Archive.

I think the same problem applies to other *-keyring packages as well.

diff --git a/manifests/source.pp b/manifests/source.pp
index a859174a1aaef9296a74bc8ec8c6acd51d096f1a..9a358fe29c972e27a6cc9d8972f30d4c83e6c0ec 100644 (file)
--- a/manifests/source.pp
+++ b/manifests/source.pp
@@ -61,6 +61,7 @@ define apt::source(
       logoutput   => 'on_failure',
       refreshonly => true,
       subscribe   => File["${name}.list"],
+      before      => Exec['apt_update'],
     }
   }
 

diff --git a/spec/defines/source_spec.rb b/spec/defines/source_spec.rb
index 0f37f6367bcbd761d966fe448caf18ea9dd71163..32aa6c8dcb11d8ceae4c74857c5320acacdd50b0 100644 (file)
--- a/spec/defines/source_spec.rb
+++ b/spec/defines/source_spec.rb
@@ -114,7 +114,8 @@ describe 'apt::source', :type => :define do
           should contain_exec("Required packages: '#{param_hash[:required_packages]}' for #{title}").with({
             "command" => "/usr/bin/apt-get -y install #{param_hash[:required_packages]}",
             "subscribe"   => "File[#{title}.list]",
-            "refreshonly" => true
+            "refreshonly" => true,
+            "before"      => 'Exec[apt_update]',
           })
         else
           should_not contain_exec("Required packages: '#{param_hash[:required_packages]}' for #{title}").with({