]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commitdiff
convert resource[:chain] to string when checking equality and just add name to array
authorJonathan Boyett <jonathan@failingservers.com>
Tue, 10 May 2011 17:07:38 +0000 (10:07 -0700)
committerJonathan Boyett <jonathan@failingservers.com>
Tue, 10 May 2011 17:07:38 +0000 (10:07 -0700)
lib/puppet/provider/firewall/iptables.rb

index d8d2692d2df3df9e8059a389236a079f85852f0f..b3d8a1d309062c56ce6d11273c4ba063d110a584 100644 (file)
@@ -142,10 +142,10 @@ Puppet::Type.type(:firewall).provide :iptables, :parent => Puppet::Provider::Fir
     
     # Find list of current rules based on chain
     self.class.instances.each do |rule|
-      next unless rule.chain == resource[:chain]
-      rules << rule
+      next unless rule.chain == resource[:chain].to_s
+      rules << rule.name
     end
-    
+
     # No rules at all? Just bail now.
     return 1 if rules.empty?