]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Fix for loadbalancer vips list
authorIlya Shakhat <ishakhat@mirantis.com>
Thu, 10 Jan 2013 15:51:40 +0000 (19:51 +0400)
committerIlya Shakhat <ishakhat@mirantis.com>
Thu, 10 Jan 2013 15:51:40 +0000 (19:51 +0400)
Fixes bug 1098165

Change-Id: I86106d39afc9d5d8c6d2d0bbdcd829baf2c1b66b

quantum/plugins/services/loadbalancer/loadbalancerPlugin.py
quantum/tests/unit/db/loadbalancer/test_db_loadbalancer.py

index 0edb6e52cdece22cf5307d68a52067504e26de7f..e1b37606c9b3b517be7cff0e2d3f7170968c470b 100644 (file)
@@ -98,7 +98,7 @@ class LoadBalancerPlugin(loadbalancer_db.LoadBalancerPluginDb):
         return res
 
     def get_vips(self, context, filters=None, fields=None):
-        res = super(LoadBalancerPlugin, self).get_vips_db(
+        res = super(LoadBalancerPlugin, self).get_vips(
             context, filters, fields)
         LOG.debug(_("Get vips"))
         return res
index 6938725aaf06a312977552306bdd53aa72a7d447..81f5b12022be5a57febd71af29bb803c3065e710 100644 (file)
@@ -456,6 +456,22 @@ class TestLoadBalancer(LoadBalancerPluginDbTestCase):
             for k, v in keys:
                 self.assertEqual(res['vip'][k], v)
 
+    def test_list_vips(self):
+        name = "vips_list"
+        keys = [('name', name),
+                ('subnet_id', self._subnet_id),
+                ('address', "172.16.1.123"),
+                ('port', 80),
+                ('protocol', 'HTTP'),
+                ('connection_limit', -1),
+                ('admin_state_up', True),
+                ('status', 'PENDING_CREATE')]
+        with self.vip(name=name):
+            req = self.new_list_request('vips')
+            res = self.deserialize('json', req.get_response(self.ext_api))
+            for k, v in keys:
+                self.assertEqual(res['vips'][0][k], v)
+
     def test_create_pool(self):
         name = "pool1"
         keys = [('name', name),