]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Don't need to init testr in run_tests.sh
authorKui Shi <skuicloud@gmail.com>
Wed, 11 Sep 2013 17:04:09 +0000 (01:04 +0800)
committerKui Shi <skuicloud@gmail.com>
Wed, 11 Sep 2013 17:04:09 +0000 (01:04 +0800)
In run_tests.sh, function init_testr will initialize testr if the
directory .testrepository is not existed. Actually, testr will do
the check before run the test:

In Python package testrepository, setuptools_command.py:Testr.run

68 def run(self):
69     """Set up testr repo, then run testr"""
70     if not os.path.isdir(".testrepository"):
71         self._run_testr("init")

So, init_testr can be removed safely.

Fixes Bug #1224285

Change-Id: Ia74d9fff92b8efba9b72e5c7387f761144daa193

run_tests.sh

index 78eb99a6c0a972188c2e6c61bce720f76859d705..cc171246c0e0df166eac2c223a16828925fce19e 100755 (executable)
@@ -102,11 +102,6 @@ if [ $no_site_packages -eq 1 ]; then
   installvenvopts="--no-site-packages"
 fi
 
-function init_testr {
-  if [ ! -d .testrepository ]; then
-    ${wrapper} testr init
-  fi
-}
 
 function run_tests {
   # Cleanup *pyc
@@ -213,7 +208,6 @@ if [ $recreate_db -eq 1 ]; then
     rm -f tests.sqlite
 fi
 
-init_testr
 run_tests
 
 # NOTE(sirp): we only want to run pep8 when we're running the full-test suite,