]> review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/commitdiff
Fix style related issues in module.
authorNan Liu <nan@puppetlabs.com>
Tue, 8 May 2012 17:47:43 +0000 (10:47 -0700)
committerNan Liu <nan@puppetlabs.com>
Tue, 8 May 2012 17:47:43 +0000 (10:47 -0700)
manifests/key.pp
manifests/ppa.pp

index e87968d7fbb504f3f6e8ca8a2e38b2e344ca8566..037eec5288f789937ca492382064715df982034e 100644 (file)
@@ -29,14 +29,14 @@ define apt::key (
   case $ensure {
     present: {
 
-      anchor { "apt::key/${title}":; }
+      anchor { "apt::key/${title}": }
 
       if defined(Exec["apt::key ${upkey} absent"]) {
         fail("Cannot ensure Apt::Key[${upkey}] present; ${upkey} already ensured absent")
       }
 
       if !defined(Anchor["apt::key ${upkey} present"]) {
-        anchor { "apt::key ${upkey} present":; }
+        anchor { "apt::key ${upkey} present": }
       }
 
       if !defined(Exec[$digest]) {
index 7800d3d388fd9efb714aa98e59df02fae1fb6e8a..578c81df7123c3f0171fddc6d222a410190a9c8d 100644 (file)
@@ -15,10 +15,9 @@ define apt::ppa(
     fail('lsbdistcodename fact not available: release parameter required')
   }
 
-
   $filename_without_slashes = regsubst($name,'/','-','G')
-  $filename_without_ppa = regsubst($filename_without_slashes, '^ppa:','','G')
-  $sources_list_d_filename = "${filename_without_ppa}-${release}.list"
+  $filename_without_ppa     = regsubst($filename_without_slashes, '^ppa:','','G')
+  $sources_list_d_filename  = "${filename_without_ppa}-${release}.list"
 
   if ! defined(Package['python-software-properties']) {
     package { 'python-software-properties': }
@@ -33,7 +32,7 @@ define apt::ppa(
 
   file { "${sources_list_d}/${sources_list_d_filename}":
     ensure  => file,
-    require => Exec["add-apt-repository-${name}"];
+    require => Exec["add-apt-repository-${name}"],
   }
 
   # Need anchor to provide containment for dependencies.