Fix incorrect tgt-admin call in create_iscsi_target

  * Fixes bug 1039826
  * Missed one of the execute cmds that was using 'val %s' as args

Change-Id: I5e6af737ada1c2bcf7a495710e2b10c8c74bb534

diff --git a/cinder/volume/iscsi.py b/cinder/volume/iscsi.py
index 4805d0c450e35aa117bdd6c481a986839e500cd7..260eb6a581fcdc93a4982897d7b2f7ec549f0ec6 100644 (file)
--- a/cinder/volume/iscsi.py
+++ b/cinder/volume/iscsi.py
@@ -116,8 +116,9 @@ class TgtAdm(TargetAdmin):
                 f.close()
 
             self._execute('tgt-admin', '--execute',
-                          '--conf %s' % volume_path,
-                          '--update %s' % vol_id, run_as_root=True)
+                          '--conf', volume_path,
+                          '--update', vol_id,
+                          run_as_root=True)
 
         except Exception as ex:
             LOG.exception(ex)