]> review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/commitdiff
[#153] Rename unattended_upgrades s/-/_/
authorDan Carley <dan.carley@gmail.com>
Mon, 16 Sep 2013 07:53:01 +0000 (08:53 +0100)
committerDan Carley <dan.carley@gmail.com>
Mon, 16 Sep 2013 07:53:01 +0000 (08:53 +0100)
It's preferable to use underscores rather than hyphens in class names. Refs:

- http://projects.puppetlabs.com/issues/5268
- http://docs.puppetlabs.com/puppet/3/reference/lang_reserved.html#classes-and-types

manifests/unattended_upgrades.pp [moved from manifests/unattended-upgrades.pp with 95% similarity]
spec/classes/unattended_upgrades_spec.rb [moved from spec/classes/unattended-upgrades_spec.rb with 99% similarity]

similarity index 95%
rename from manifests/unattended-upgrades.pp
rename to manifests/unattended_upgrades.pp
index 772ab047cbd1841ce8ff096afc2b633cb0d291e5..e4ad4dc4115c923cfeaeec01259df272597c880d 100644 (file)
@@ -1,19 +1,19 @@
-# unattended-upgrades.pp
-
+# Class: apt::unattended_upgrades
+#
 # This class manages the unattended-upgrades package and related configuration
 # files for ubuntu
-
+#
 # origins are the repositories to automatically upgrade included packages
 # blacklist is a list of packages to not automatically upgrade
 # update is how often to run "apt-get update" in days
 # download is how often to run "apt-get upgrade --download-only" in days
 # upgrade is how often to upgrade packages included in the origins list in days
 # autoclean is how often to run "apt-get autoclean" in days
-
+#
 # information on the other options can be found in the 50unattended-upgrades
 # file and in /etc/cron.daily/apt
-
-class apt::unattended-upgrades (
+#
+class apt::unattended_upgrades (
   $origins = ['${distro_id}:${distro_codename}-security'],
   $blacklist = [],
   $update = "1",
similarity index 99%
rename from spec/classes/unattended-upgrades_spec.rb
rename to spec/classes/unattended_upgrades_spec.rb
index 98245ca8a5deb63f4b88208f10f694674056ae9d..6695550abc7dd36df7a84b82c9101cce275ae6b4 100644 (file)
@@ -1,5 +1,5 @@
 require 'spec_helper'
-describe 'apt::unattended-upgrades', :type => :class do
+describe 'apt::unattended_upgrades', :type => :class do
 
   it { should contain_package("unattended-upgrades") }