]> review.fuel-infra Code Review - puppet-modules/puppet-ceilometer.git/commitdiff
Accept empty strings for log_dir
authorJuan Antonio Osorio Robles <jaosorior@redhat.com>
Fri, 6 Oct 2017 10:00:04 +0000 (13:00 +0300)
committerJuan Antonio Osorio Robles <jaosorior@redhat.com>
Fri, 6 Oct 2017 10:00:04 +0000 (13:00 +0300)
An empty string is an acceptable value of this entry, and it forces
logging to stdout/stderr, which is useful when running on containers.

Change-Id: I392d113c13cb6ba77e1bbcaf1b37c54c8b0eb1a5

manifests/logging.pp

index c8eb0cababcf879616f3f4332e561ff7af3fb866..748b91c7ddab984d7f2058a8667c0361e00645a4 100644 (file)
@@ -111,7 +111,11 @@ class ceilometer::logging(
   $use_syslog_real = pick($::ceilometer::use_syslog,$use_syslog)
   $use_stderr_real = pick($::ceilometer::use_stderr,$use_stderr)
   $log_facility_real = pick($::ceilometer::log_facility,$log_facility)
-  $log_dir_real = pick($::ceilometer::log_dir,$log_dir)
+  if $log_dir != '' {
+    $log_dir_real = pick($::ceilometer::log_dir,$log_dir)
+  } else {
+    $log_dir_real = $log_dir
+  }
   $debug_real = pick($::ceilometer::debug,$debug)
 
   oslo::log { 'ceilometer_config':