]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commitdiff
Added iptables-persistent fix for Debian 8 and Ubuntu 14.10
authorJonathan Tripathy <jt@puppetlabs.com>
Wed, 6 May 2015 15:49:08 +0000 (16:49 +0100)
committerJonathan Tripathy <jt@puppetlabs.com>
Wed, 6 May 2015 16:25:45 +0000 (17:25 +0100)
manifests/params.pp
metadata.json
spec/unit/classes/firewall_linux_debian_spec.rb

index c8e2ade64254f0285f1a6c8e2297007c3ddfdbb8..9d0f64d1ab628d6285d50f52e9bcd780306817de 100644 (file)
@@ -33,7 +33,7 @@ class firewall::params {
         'Debian': {
           if versioncmp($::operatingsystemrelease, '8.0') >= 0 {
             $service_name = 'netfilter-persistent'
-            $package_name = 'netfilter-persistent'
+            $package_name = 'iptables-persistent'
           } else {
             $service_name = 'iptables-persistent'
             $package_name = 'iptables-persistent'
@@ -43,7 +43,7 @@ class firewall::params {
         'Ubuntu': {
           if versioncmp($::operatingsystemrelease, '14.10') >= 0 {
             $service_name = 'netfilter-persistent'
-            $package_name = 'netfilter-persistent'
+            $package_name = 'iptables-persistent'
           } else {
             $service_name = 'iptables-persistent'
             $package_name = 'iptables-persistent'
index cd452af1fd60441994d37ee0fba2c5569ff9dc67..65099d0f4e9206e5b89d2bf5692fb187452b9316 100644 (file)
@@ -50,7 +50,8 @@
       "operatingsystem": "Debian",
       "operatingsystemrelease": [
         "6",
-        "7"
+        "7",
+        "8"
       ]
     },
     {
index f7817435531762140c799e80ecbfc4f1718b1ef9..e8af543966202273e91fbe11a46d5814502d46aa 100644 (file)
@@ -35,13 +35,13 @@ describe 'firewall::linux::debian', :type => :class do
         :operatingsystem       => 'Debian',
         :operatingsystemrelease => 'jessie/sid'
     }}
-    it { should contain_package('netfilter-persistent').with(
+    it { should contain_package('iptables-persistent').with(
       :ensure => 'present'
     )}
     it { should contain_service('netfilter-persistent').with(
       :ensure   => nil,
       :enable   => 'true',
-      :require  => 'Package[netfilter-persistent]'
+      :require  => 'Package[iptables-persistent]'
     )}
   end
 
@@ -63,13 +63,13 @@ describe 'firewall::linux::debian', :type => :class do
         :operatingsystem        => 'Debian',
         :operatingsystemrelease => '8.0'
     }}
-    it { should contain_package('netfilter-persistent').with(
+    it { should contain_package('iptables-persistent').with(
       :ensure => 'present'
     )}
     it { should contain_service('netfilter-persistent').with(
       :ensure   => nil,
       :enable   => 'true',
-      :require  => 'Package[netfilter-persistent]'
+      :require  => 'Package[iptables-persistent]'
     )}
   end