]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Add a missing mock in DHCPAgentWeightSchedulerTestCase
authorYAMAMOTO Takashi <yamamoto@valinux.co.jp>
Thu, 19 Mar 2015 07:54:51 +0000 (16:54 +0900)
committerYAMAMOTO Takashi <yamamoto@valinux.co.jp>
Thu, 19 Mar 2015 08:02:30 +0000 (17:02 +0900)
start_periodic_dhcp_agent_status_check needs to be mocked
when instantiating ml2 plugin.

The test case in question was introduced by
change I5ec8adf0c4336f885d603662223caa7694708876.

Closes-Bug: #1433944
Change-Id: I2d0b57e37d10b6dbd1a06dc7bba004890e238ce6

neutron/tests/unit/test_dhcp_scheduler.py

index a50173356bc4fede56199fd45cbfefc92c18031b..36a2ba1306d56f21f225789e837111e38f82e447 100644 (file)
@@ -297,8 +297,13 @@ class DHCPAgentWeightSchedulerTestCase(TestDhcpSchedulerBaseTestCase):
         cfg.CONF.set_override("core_plugin", DB_PLUGIN_KLASS)
         cfg.CONF.set_override("network_scheduler_driver",
             'neutron.scheduler.dhcp_agent_scheduler.WeightScheduler')
+        self.dhcp_periodic_p = mock.patch(
+            'neutron.db.agentschedulers_db.DhcpAgentSchedulerDbMixin.'
+            'start_periodic_dhcp_agent_status_check')
+        self.patched_dhcp_periodic = self.dhcp_periodic_p.start()
         self.plugin = importutils.import_object('neutron.plugins.ml2.plugin.'
                                                 'Ml2Plugin')
+        self.assertEqual(1, self.patched_dhcp_periodic.call_count)
         self.plugin.network_scheduler = importutils.import_object(
             'neutron.scheduler.dhcp_agent_scheduler.WeightScheduler'
         )