]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
CoraidDriver: do not call login from __init__
authorJean-Baptiste RANSY <jean-baptiste.ransy@alyseo.com>
Thu, 21 Mar 2013 11:08:53 +0000 (12:08 +0100)
committerJean-Baptiste RANSY <jean-baptiste.ransy@alyseo.com>
Thu, 21 Mar 2013 11:08:53 +0000 (12:08 +0100)
We should not call _login from the driver's __init__.
If the ESM is down, the constructor will fail.

- self._login()

Fixes bug 1157500

Change-Id: Ie57fbb6d3704d270a81cd9eb056d7988989da1f8

cinder/volume/drivers/coraid.py

index 260a48aeae70813d1de01207b689ddf5622245f5..ef188f0030320ebe0f0cb8bce30fd18643909271 100644 (file)
@@ -83,7 +83,6 @@ class CoraidRESTClient(object):
         self.urlOpener = urllib2.build_opener(
             urllib2.HTTPCookieProcessor(self.cookiejar))
         LOG.debug(_('Running with CoraidDriver for ESM EtherCLoud'))
-        self._login()
 
     def _login(self):
         """Login and Session Handler."""