]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Changes to cast variable as integer as XML API fails.
authorGlenn M. Gobeli <Glenn.Gobeli@netapp.com>
Tue, 11 Feb 2014 18:03:13 +0000 (13:03 -0500)
committerGlenn M. Gobeli <Glenn.Gobeli@netapp.com>
Tue, 11 Feb 2014 18:23:23 +0000 (13:23 -0500)
Code change to ensure that the type of the size variable is correct
when cinder is invoked through XML API. The extend volume code path
differs from volume create where the flow portion verifies that the
size variable is an integer; for extend the earliest place to cast
the size variable is in volume_actions.py.

Change-Id: Iaaed463f988769b8093604cd3b677b270dd2c5cd
Closes-bug: 1277233

cinder/api/contrib/volume_actions.py

index 2e87b4e0faee69dea0a9994309583dd2afc498ff..ebe24485d16dda51d597d564826fad34b98d1448 100644 (file)
@@ -280,7 +280,7 @@ class VolumeActionsController(wsgi.Controller):
             msg = _("New volume size must be specified as an integer.")
             raise webob.exc.HTTPBadRequest(explanation=msg)
 
-        size = body['os-extend']['new_size']
+        size = int(body['os-extend']['new_size'])
         self.volume_api.extend(context, volume, size)
         return webob.Response(status_int=202)