]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commitdiff
(#12897) Require jump=>LOG for log params
authorDaniel Black <grooverdan@users.sourceforge.net>
Sun, 18 Dec 2011 09:16:19 +0000 (20:16 +1100)
committerDan Carley <dan.carley@gmail.com>
Thu, 8 Mar 2012 15:54:32 +0000 (15:54 +0000)
This validates that when log_prefix or log_level is specified the jump
should be 'LOG'

lib/puppet/type/firewall.rb

index f8cc35832fa841bdab20e1f93dd7deef5a788700..4843895c3cfd8f02d4080757b1917b33d10f06fe 100644 (file)
@@ -570,6 +570,12 @@ Puppet::Type.newtype(:firewall) do
       end
     end
 
+    if value(:log_prefix) || value(:log_level)
+      unless value(:jump).to_s == "LOG"
+        self.fail "Parameter log_prefix and log_level require jump => LOG"
+      end
+    end
+
     if value(:burst) && ! value(:limit)
       self.fail "burst makes no sense without limit"
     end