]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Do not explicitly set mysql_engine
authorSalvatore Orlando <salv.orlando@gmail.com>
Mon, 25 Aug 2014 11:52:49 +0000 (04:52 -0700)
committerSalvatore Orlando <salv.orlando@gmail.com>
Mon, 25 Aug 2014 11:52:49 +0000 (04:52 -0700)
Setting the mysql_engine when creating a table is not needed
anymore as this is automatically done by an event listener
added with commit 466e89970f11918a809aafe8a048d138d4664299

Change-Id: I0df978dbf2bb44f17102da3c17fd4e93c9e4df8d
Closes-Bug: #1361176

neutron/db/migration/alembic_migrations/versions/19180cf98af6_nsx_gw_devices.py
neutron/db/migration/alembic_migrations/versions/3c6e57a23db4_add_multiprovider.py
neutron/db/migration/alembic_migrations/versions/4a666eb208c2_service_router.py

index fafb85a511a29741680ae84a73cb8cfae44f73bf..c5972444ee0ba42afabf673e8895899a5186def8 100644 (file)
@@ -51,8 +51,7 @@ def upgrade(active_plugins=None, options=None):
         sa.Column('interface_name', sa.String(length=64), nullable=True),
         sa.ForeignKeyConstraint(['network_gateway_id'], ['networkgateways.id'],
                                 ondelete='CASCADE'),
-        sa.PrimaryKeyConstraint('id', 'network_gateway_id', 'interface_name'),
-        mysql_engine='InnoDB')
+        sa.PrimaryKeyConstraint('id', 'network_gateway_id', 'interface_name'))
     # Copy data from networkgatewaydevices into networkgatewaydevicereference
     op.execute("INSERT INTO networkgatewaydevicereferences SELECT "
                "id, network_gateway_id, interface_name FROM "
@@ -68,8 +67,7 @@ def upgrade(active_plugins=None, options=None):
         sa.Column('connector_type', sa.String(length=10), nullable=True),
         sa.Column('connector_ip', sa.String(length=64), nullable=True),
         sa.Column('status', sa.String(length=16), nullable=True),
-        sa.PrimaryKeyConstraint('id'),
-        mysql_engine='InnoDB')
+        sa.PrimaryKeyConstraint('id'))
     # Create a networkgatewaydevice for each existing reference.
     # For existing references nsx_id == neutron_id
     # Do not fill conenctor info as they would be unknown
@@ -93,8 +91,7 @@ def downgrade(active_plugins=None, options=None):
         sa.Column('interface_name', sa.String(length=64), nullable=True),
         sa.ForeignKeyConstraint(['network_gateway_id'], ['networkgateways.id'],
                                 ondelete='CASCADE'),
-        sa.PrimaryKeyConstraint('id'),
-        mysql_engine='InnoDB')
+        sa.PrimaryKeyConstraint('id'))
     # Copy from networkgatewaydevicereferences to networkgatewaydevices
     op.execute("INSERT INTO networkgatewaydevices SELECT "
                "id, network_gateway_id, interface_name FROM "
index 1b134fae783ce1b851df9f5cbc0474cbc01a8125..880f6460c4559638689407695851984c6fe71ad6 100644 (file)
@@ -64,9 +64,7 @@ def upgrade(active_plugins=None, options=None):
         sa.Column('network_id', sa.String(length=36), nullable=False),
         sa.ForeignKeyConstraint(['network_id'], ['networks.id'],
                                 ondelete='CASCADE'),
-        sa.PrimaryKeyConstraint('network_id'),
-        mysql_engine='InnoDB'
-    )
+        sa.PrimaryKeyConstraint('network_id'))
     op.create_table('rename_nvp_network_bindings',
                     sa.Column('network_id', sa.String(length=36),
                               primary_key=True),
index ad3356b45ddd1e33b15c5b5ad7a2659824bc0fac..8123ac1e485874dedab704c54f8e90c2540c5896 100644 (file)
@@ -53,9 +53,7 @@ def upgrade(active_plugins=None, options=None):
         sa.Column('router_id', sa.String(length=36), nullable=False),
         sa.Column('edge_id', sa.String(length=16), nullable=True),
         sa.Column('lswitch_id', sa.String(length=36), nullable=False),
-        sa.PrimaryKeyConstraint('router_id'),
-        mysql_engine='InnoDB'
-    )
+        sa.PrimaryKeyConstraint('router_id'))
     op.add_column(
         u'nsxrouterextattributess',
         sa.Column('service_router', sa.Boolean(), nullable=False))