]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Update URL for global HACKING document and remove duplicate section
authorJoe Gordon <joe.gordon0@gmail.com>
Mon, 11 Nov 2013 19:28:18 +0000 (11:28 -0800)
committerJoe Gordon <joe.gordon0@gmail.com>
Mon, 11 Nov 2013 19:39:23 +0000 (11:39 -0800)
* Related to I579e7c889f3addc2cd40bce0c584bbc70bf435e2

* Remove section on locals since its already in global hacking doc
  (http://git.openstack.org/cgit/openstack-dev/hacking/tree/doc/source/index.rst#n154)

Change-Id: I5acb06dfde6eb7f579d8d52bc31fafbdab8c726d

HACKING.rst

index ca8dbf0f8a9e2d7c0a7cbd9f584d4e7a800f0999..4c5a00de53680afa30a467edf5d07ce122f977ce 100644 (file)
@@ -2,7 +2,7 @@ Cinder Style Commandments
 =========================
 
 - Step 1: Read the OpenStack Style Commandments
-  https://github.com/openstack-dev/hacking/blob/master/doc/source/index.rst
+  http://docs.openstack.org/developer/hacking/
 - Step 2: Read on
 
 Cinder Specific Commandments
@@ -10,15 +10,6 @@ Cinder Specific Commandments
 
 General
 -------
-- Do not use locals(). Example::
-
-    LOG.debug(_("volume %(vol_name)s: creating size %(vol_size)sG") %
-              locals()) # BAD
-
-    LOG.debug(_("volume %(vol_name)s: creating size %(vol_size)sG") %
-              {'vol_name': vol_name,
-               'vol_size': vol_size}) # OKAY
-
 - Use 'raise' instead of 'raise e' to preserve original traceback or exception being reraised::
 
     except Exception as e: