]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commitdiff
pdksync_heads/master-0-gabccfb1 pdksync_pdksync_heads/master-0-gabccfb1
authorDavid Swan <david.swan@puppet.com>
Wed, 7 Nov 2018 10:21:51 +0000 (10:21 +0000)
committerDavid Swan <david.swan@puppet.com>
Wed, 7 Nov 2018 10:21:51 +0000 (10:21 +0000)
metadata.json
spec/spec_helper.rb

index e6378f0ee6795333352b5f8e9c098b60fc271c2d..35888d815ab86847954b2ef736fa4253c551f1f6 100644 (file)
@@ -74,6 +74,6 @@
     }
   ],
   "template-url": "https://github.com/puppetlabs/pdk-templates",
-  "template-ref": "heads/master-0-g8fc95db",
+  "template-ref": "heads/master-0-gabccfb1",
   "pdk-version": "1.7.0"
 }
index 5e721b7ff4d57a0388bb30676ba8ccc3cf5dd477..a7281d530037b7c417fa03ab50dad09176ff2b1d 100644 (file)
@@ -1,11 +1,7 @@
 require 'puppetlabs_spec_helper/module_spec_helper'
 require 'rspec-puppet-facts'
 
-begin
-  require 'spec_helper_local' if File.file?(File.join(File.dirname(__FILE__), 'spec_helper_local.rb'))
-rescue LoadError => loaderror
-  warn "Could not require spec_helper_local: #{loaderror.message}"
-end
+require 'spec_helper_local' if File.file?(File.join(File.dirname(__FILE__), 'spec_helper_local.rb'))
 
 include RspecPuppetFacts
 
@@ -14,15 +10,19 @@ default_facts = {
   facterversion: Facter.version,
 }
 
-default_facts_path = File.expand_path(File.join(File.dirname(__FILE__), 'default_facts.yml'))
-default_module_facts_path = File.expand_path(File.join(File.dirname(__FILE__), 'default_module_facts.yml'))
+default_fact_files = [
+  File.expand_path(File.join(File.dirname(__FILE__), 'default_facts.yml')),
+  File.expand_path(File.join(File.dirname(__FILE__), 'default_module_facts.yml')),
+]
 
-if File.exist?(default_facts_path) && File.readable?(default_facts_path)
-  default_facts.merge!(YAML.safe_load(File.read(default_facts_path)))
-end
+default_fact_files.each do |f|
+  next unless File.exist?(f) && File.readable?(f) && File.size?(f)
 
-if File.exist?(default_module_facts_path) && File.readable?(default_module_facts_path)
-  default_facts.merge!(YAML.safe_load(File.read(default_module_facts_path)))
+  begin
+    default_facts.merge!(YAML.safe_load(File.read(f)))
+  rescue => e
+    RSpec.configuration.reporter.message "WARNING: Unable to load #{f}: #{e}"
+  end
 end
 
 RSpec.configure do |c|