]> review.fuel-infra Code Review - puppet-modules/puppet-ceilometer.git/commitdiff
Add memcached_servers for keystone authtoken
authorAlex Schultz <aschultz@mirantis.com>
Thu, 30 Jun 2016 17:09:01 +0000 (11:09 -0600)
committerAlex Schultz <aschultz@mirantis.com>
Thu, 30 Jun 2016 17:09:01 +0000 (11:09 -0600)
This change adds the abiltity to manage the memcached servers for the
keystone authtoken configuration in ceilometer::api

Change-Id: I5fe1ec35630a67fe08b5c7b475593c34044110e8

manifests/api.pp
releasenotes/notes/keystone-authtoken-memcached-ab13c488a438804d.yaml [new file with mode: 0644]
spec/classes/ceilometer_api_spec.rb

index 4297bf8e5cc40661f75601e15ed479eae70ec6b7..f833f6f58b721afd7777b203c668e7fc176559da 100644 (file)
 # [*keystone_password*]
 #   (Required) Password to authenticate with.
 #
+# [*memcached_servers*]
+#   (optinal) a list of memcached server(s) to use for caching. If left
+#   undefined, tokens will instead be cached in-process.
+#   Defaults to $::os_service_default.
+#
 # [*auth_uri*]
 #   (Optional) Public Identity API endpoint.
 #   Defaults to 'http://127.0.0.1:5000/'.
@@ -77,6 +82,7 @@ class ceilometer::api (
   $keystone_user              = 'ceilometer',
   $keystone_tenant            = 'services',
   $keystone_password          = false,
+  $memcached_servers          = $::os_service_default,
   $auth_uri                   = 'http://127.0.0.1:5000/',
   $identity_uri               = 'http://127.0.0.1:35357/',
   $host                       = '0.0.0.0',
@@ -145,6 +151,7 @@ class ceilometer::api (
     'keystone_authtoken/admin_tenant_name' : value => $keystone_tenant;
     'keystone_authtoken/admin_user'        : value => $keystone_user;
     'keystone_authtoken/admin_password'    : value => $keystone_password, secret => true;
+    'keystone_authtoken/memcached_servers' : value => join(any2array($memcached_servers), ',');
     'api/host'                             : value => $host;
     'api/port'                             : value => $port;
   }
diff --git a/releasenotes/notes/keystone-authtoken-memcached-ab13c488a438804d.yaml b/releasenotes/notes/keystone-authtoken-memcached-ab13c488a438804d.yaml
new file mode 100644 (file)
index 0000000..a136f7d
--- /dev/null
@@ -0,0 +1,4 @@
+---
+fixes:
+  - Added the ability to manage the memcached servers
+    for keystone_authtoken in ceilometer::api
index 27b70e8ef9730fea63d61ac24772fb7a7c440b3a..34a56dfda944ae0f23751a812ff60605944a3073 100644 (file)
@@ -44,6 +44,7 @@ describe 'ceilometer::api' do
       is_expected.to contain_ceilometer_config('keystone_authtoken/admin_password').with_value( params[:keystone_password] ).with_secret(true)
       is_expected.to contain_ceilometer_config('keystone_authtoken/auth_uri').with_value("http://127.0.0.1:5000/")
       is_expected.to contain_ceilometer_config('keystone_authtoken/identity_uri').with_value("http://127.0.0.1:35357/")
+      is_expected.to contain_ceilometer_config('keystone_authtoken/memcached_servers').with_value('<SERVICE DEFAULT>')
       is_expected.to contain_ceilometer_config('api/host').with_value( params[:host] )
       is_expected.to contain_ceilometer_config('api/port').with_value( params[:port] )
       is_expected.to contain_ceilometer_config('api/workers').with_value('<SERVICE DEFAULT>')
@@ -69,6 +70,16 @@ describe 'ceilometer::api' do
       end
     end
 
+    context 'with memcached servers' do
+      before do
+        params.merge!({ :memcached_servers => '1.1.1.1:11211', })
+      end
+
+      it 'configures ceilometer-api service' do
+        is_expected.to contain_ceilometer_config('keystone_authtoken/memcached_servers').with_value('1.1.1.1:11211')
+      end
+    end
+
     context 'with disabled service managing' do
       before do
         params.merge!({