]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Remove unused return values and commented out code from NFS driver
authorBen Swartzlander <bswartz@netapp.com>
Wed, 29 Aug 2012 23:10:11 +0000 (19:10 -0400)
committerBen Swartzlander <bswartz@netapp.com>
Wed, 29 Aug 2012 23:10:11 +0000 (19:10 -0400)
bug 1037622

Change-Id: Idea3005ad94fd6bfc76fd0f3969ee78e3031767e

cinder/volume/nfs.py

index 5ea23674ca2c49465d68ff5293e93af4e7905881..ed894efdc422f40284b61b639704d211e520dd56 100644 (file)
@@ -107,7 +107,7 @@ class NfsDriver(driver.VolumeDriver):
         if not volume['provider_location']:
             LOG.warn(_('Volume %s does not have provider_location specified, '
                      'skipping'), volume['name'])
-            return True
+            return
 
         self._ensure_share_mounted(volume['provider_location'])
 
@@ -118,10 +118,8 @@ class NfsDriver(driver.VolumeDriver):
 
             LOG.warn(_('Trying to delete non-existing volume %(volume)s at '
                      'path %(mounted_path)s') % locals())
-            return True
+            return
 
-#        self._execute('dd', 'if=/dev/zero', 'of=%s' % mounted_volume_path,
-#                      'bs=1M', run_as_root=True)
         self._execute('rm', '-f', mounted_path, run_as_root=True)
 
     def ensure_export(self, ctx, volume):