]> review.fuel-infra Code Review - puppet-modules/puppetlabs-apt.git/commitdiff
reformatted apt::ppa according to recommended
authorDan Bode <dan@puppetlabs.com>
Mon, 30 May 2011 17:22:04 +0000 (10:22 -0700)
committerDan Bode <dan@puppetlabs.com>
Mon, 30 May 2011 17:25:11 +0000 (10:25 -0700)
style.

removed require apt in favor of marking a
dependency.

converted release define into a class since
the resources are singletons.

manifests/ppa.pp
manifests/release.pp

index 9c277e9bd4534ec35d7859a17706e5a1616f2ec4..dd2143e246aea2e35e46bf69ba2004b29a9bec20 100644 (file)
@@ -1,9 +1,8 @@
 # ppa.pp
 
-define apt::ppa(
+define apt::ppa() {
 
-) {
-    require apt
+  Class['apt'] -> Apt::Ppa[$title]
 
     exec { "apt-update-${name}":
         command     => "/usr/bin/aptitude update",
index 7e00dba642e79483624272f521c6c58ee4d01332..6df52a999190ca25fa950166798f0eee023baca6 100644 (file)
@@ -1,15 +1,15 @@
 # release.pp
 
-define apt::release (
-
+class apt::release (
+  $release_id
 ) {
 
                owner => root,
                group => root,
                mode => 644,
-               content => "APT::Default-Release \"${name}\";"
        }
   include apt::params
 
   file { "${apt::params::root}/apt.conf.d/01release":
+    content => "APT::Default-Release \"${release_id}\";"
 }