]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Brick LVM: Remove self.lv_list
authorEric Harney <eharney@redhat.com>
Mon, 17 Nov 2014 20:01:02 +0000 (15:01 -0500)
committerEric Harney <eharney@redhat.com>
Tue, 23 Dec 2014 20:07:45 +0000 (15:07 -0500)
This member isn't used anywhere, and now that requests for
specific LVs are overwriting self.lv_list with a subset of
the LVs that are present, it doesn't contain coherent info
anyway.

Change-Id: I4d661869012937cc40177e53c8546d5cd7c98cd9

cinder/brick/local_dev/lvm.py

index 4c926484466c6844bb45ce7d5f1937ef73f76368..9d2cdf7ff6eb1c95c8fe1d78c23f09bc339edcd7 100644 (file)
@@ -58,7 +58,6 @@ class LVM(executor.Executor):
         super(LVM, self).__init__(execute=executor, root_helper=root_helper)
         self.vg_name = vg_name
         self.pv_list = []
-        self.lv_list = []
         self.vg_size = 0.0
         self.vg_free_space = 0.0
         self.vg_lv_count = 0
@@ -287,10 +286,9 @@ class LVM(executor.Executor):
         :returns: List of Dictionaries with LV info
 
         """
-        self.lv_list = self.get_lv_info(self._root_helper,
-                                        self.vg_name,
-                                        lv_name)
-        return self.lv_list
+        return self.get_lv_info(self._root_helper,
+                                self.vg_name,
+                                lv_name)
 
     def get_volume(self, name):
         """Get reference object of volume specified by name.