]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Python 3: do not do "assertFalse(filter(...))"
authorCyril Roelandt <cyril@redhat.com>
Fri, 21 Aug 2015 09:56:42 +0000 (11:56 +0200)
committerCyril Roelandt <cyril@redhat.com>
Fri, 21 Aug 2015 13:28:07 +0000 (15:28 +0200)
This does not work in Python 3 since filter does not return a list. Fix this by
replacing it with a list comprehension.

Blueprint: neutron-python3
Change-Id: I59a63f7adedaf2217aa8fc9aae63045b4e620361

neutron/tests/unit/objects/test_base.py

index 381ff8b29fc3f480eeab1b307d53e20e03d8bd1a..71a0dd2e66e4e4807dda509fe0f5efe5ca2b5fde 100644 (file)
@@ -182,8 +182,7 @@ class BaseObjectIfaceTestCase(_BaseObjectTestCase, test_base.BaseTestCase):
                               fake_field='xxx')
 
     def _validate_objects(self, expected, observed):
-        self.assertFalse(
-            filter(lambda obj: not self._is_test_class(obj), observed))
+        self.assertTrue(all(self._is_test_class(obj) for obj in observed))
         self.assertEqual(
             sorted(expected),
             sorted(get_obj_db_fields(obj) for obj in observed))