Give clearer instructions around lsb-release

diff --git a/README.md b/README.md
index e8e6d39bd345571bddc682007a669d393f788425..79a0dec5e5415b83010457c66e2fbe850b4a2c1b 100644 (file)
--- a/README.md
+++ b/README.md
@@ -24,6 +24,8 @@ The apt module lets you use Puppet to manage Apt sources, keys, and other config
 
 Apt (Advanced Package Tool) is a package manager available on Debian, Ubuntu, and several other operating systems. The apt module provides a series of classes, defines, types, and facts to help you automate Apt package management.
 
+**Note**: For this module to be able to correctly auto detect which version of Debian/Ubuntu or derivative you're running you need to make sure the 'lsb-release' package is installed. We highly recommend making this part of your provisioning layer if you run many Debian or derivative systems or ensuring that you have at least Facter 2.2.0 installed which will pull in this dependency for you.
+
 ## Setup
 
 ### What apt affects

diff --git a/manifests/params.pp b/manifests/params.pp
index 32e4dbae6f6a936f109fbd73d373fd26c8733272..0b1afe74aa66b0bcde2d50aa63edbb64188270ce 100644 (file)
--- a/manifests/params.pp
+++ b/manifests/params.pp
@@ -150,7 +150,7 @@ class apt::params {
       }
     }
     undef: {
-      fail('Unable to determine lsbdistid, is lsb-release installed?')
+      fail('Unable to determine lsbdistid, please install lsb-release first')
     }
     default: {
       $ppa_options = undef

diff --git a/spec/classes/params_spec.rb b/spec/classes/params_spec.rb
index e28296b2cc9e2ce1f0bb1692500ee19788d884d8..5d7236ecaa3d3c8aa26595687a8b10cf69feb44f 100644 (file)
--- a/spec/classes/params_spec.rb
+++ b/spec/classes/params_spec.rb
@@ -19,7 +19,7 @@ describe 'apt::params', :type => :class do
     it do
       expect {
         subject.call
-      }.to raise_error(Puppet::Error, /Unable to determine lsbdistid, is lsb-release installed/)
+      }.to raise_error(Puppet::Error, /Unable to determine lsbdistid, please install lsb-release first/)
     end
   end