]> review.fuel-infra Code Review - openstack-build/heat-build.git/commitdiff
RPC API: Get rid of event_create call
authorZane Bitter <zbitter@redhat.com>
Fri, 16 Nov 2012 14:50:03 +0000 (15:50 +0100)
committerZane Bitter <zbitter@redhat.com>
Fri, 16 Nov 2012 15:03:40 +0000 (16:03 +0100)
Nothing is using this.

Change-Id: Id97ce0af1e176463b92288022765f80e1b5152ed
Signed-off-by: Zane Bitter <zbitter@redhat.com>
heat/engine/rpcapi.py
heat/engine/service.py
heat/tests/test_rpcapi.py

index 764d32fc4e9e7763ad748b7526536cfe42bb45fd..92254b273a9b80f59880e816b588aa72c78bf8f1 100644 (file)
@@ -207,11 +207,6 @@ class EngineAPI(heat.openstack.common.rpc.proxy.RpcProxy):
                          resource_name=resource_name, metadata=metadata),
                          topic=_engine_topic(self.topic, ctxt, None))
 
-    def event_create(self, ctxt, event):
-        return self.call(ctxt, self.make_msg('event_create',
-                         event=event),
-                         topic=_engine_topic(self.topic, ctxt, None))
-
     def create_watch_data(self, ctxt, watch_name, stats_data):
         '''
         This could be used by CloudWatch and WaitConditions
index fcac3341cbf8feb84afb68074b3c474aadd6e2c9..0e9638b33d548dc5cdac9fea8eb1f22df78975f2 100644 (file)
@@ -286,33 +286,6 @@ class EngineService(service.Service):
 
         return {'events': [api.format_event(context, e) for e in events]}
 
-    def event_create(self, context, event):
-        stack_name = event['stack']
-        resource_name = event['resource']
-        stack = db_api.stack_get_by_name(context, stack_name)
-        resource = db_api.resource_get_by_name_and_stack(context,
-                                                         resource_name,
-                                                         stack.id)
-        if not resource:
-            return ['Unknown resource', None]
-        new_event = {
-            'name': event['message'],
-            'resource_status_reason': event['reason'],
-            'StackId': stack.id,
-            'LogicalResourceId': resource.name,
-            'PhysicalResourceId': None,
-            'ResourceType': event['resource_type'],
-            'ResourceProperties': {},
-        }
-        try:
-            result = db_api.event_create(context, new_event)
-            new_event['id'] = result.id
-            return [None, new_event]
-        except Exception as ex:
-            logger.warn('db error %s' % str(ex))
-            msg = 'Error creating event'
-            return [msg, None]
-
     def describe_stack_resource(self, context, stack_identity, resource_name):
         s = self._get_stack(context, stack_identity)
 
index 4e354d1d4e9b593d4b7529c60d53ffe34e00f5d2..5112c5c9d7d58e207dd2d1ef2f57bd72a82f1f84 100644 (file)
@@ -143,14 +143,6 @@ class EngineRpcAPITestCase(unittest.TestCase):
                               resource_name='LogicalResourceId',
                               metadata={u'wordpress': []})
 
-    def test_event_create(self):
-        self._test_engine_api('event_create', 'call',
-                              event={
-                                     'stack': 'wordpress',
-                                     'resource': 'LogicalResourceId',
-                                     'message': 'Foo',
-                                     'reason': 'Bar'})
-
     def test_create_watch_data(self):
         self._test_engine_api('create_watch_data', 'call',
                               watch_name='watch1',