]> review.fuel-infra Code Review - openstack-build/heat-build.git/commitdiff
Attempt to delete resources even if they failed
authorZane Bitter <zbitter@redhat.com>
Mon, 8 Apr 2013 10:43:35 +0000 (12:43 +0200)
committerZane Bitter <zbitter@redhat.com>
Mon, 8 Apr 2013 10:43:35 +0000 (12:43 +0200)
To do otherwise risks leaving resources silently running that exist but
have experienced some kind of error during creation.

Fixes bug 1165023

Change-Id: Ie60fb053b1a596d102ca1b6a8429dd50ed41ff92

heat/engine/resource.py

index bcfef8d209cf11c5cf955bb9bdd406d432e14a28..ccd5d133723456d34e7f51aa57cd85b64bedea36 100644 (file)
@@ -396,11 +396,7 @@ class Resource(object):
             return
         if self.state == self.DELETE_IN_PROGRESS:
             return 'Resource deletion already in progress'
-        if self.state == self.CREATE_FAILED:
-            return
-        # Further resources will not be created in a CREATE_FAILED stack.
-        # The state of these resources is None.  Do not delete as an
-        # undeleteable stack will result
+        # No need to delete if the resource has never been created
         if self.state is None:
             return