]> review.fuel-infra Code Review - openstack-build/heat-build.git/commitdiff
heat engine : don't treat UPDATE_COMPLETE as failure
authorSteven Hardy <shardy@redhat.com>
Tue, 29 Jan 2013 16:02:32 +0000 (16:02 +0000)
committerSteven Hardy <shardy@redhat.com>
Thu, 31 Jan 2013 10:28:46 +0000 (10:28 +0000)
The parser update logic currently treats UPDATE_COMPLETE
as a failure, which is incorrect

Change-Id: Ibac98fc08cdf3653be80cedfc3ed8ecb5c3eba8f
Signed-off-by: Steven Hardy <shardy@redhat.com>
heat/engine/parser.py

index 9bc2b64243ad2ab93a0720a33b761e73e0519125..a469236ef8e5ed9e0b6c8c1dffa831eedacd41a0 100644 (file)
@@ -323,7 +323,10 @@ class Stack(object):
                         # Can fail if underlying resource class does not
                         # implement update logic or update requires replacement
                         retval = self[res.name].update(new_snippet)
-                        if retval == self[res.name].UPDATE_REPLACE:
+                        if retval == self[res.name].UPDATE_COMPLETE:
+                            logger.info("Resource %s for stack %s updated" %
+                                        (res.name, self.name))
+                        elif retval == self[res.name].UPDATE_REPLACE:
                             logger.info("Resource %s for stack %s" %
                                         (res.name, self.name) +
                                         " update requires replacement")