]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Add missing methods to NoopFirewallDriver
authorEugene Nikanorov <enikanorov@mirantis.com>
Mon, 15 Sep 2014 18:10:45 +0000 (22:10 +0400)
committerKyle Mestery <mestery@mestery.com>
Tue, 7 Oct 2014 15:58:52 +0000 (15:58 +0000)
The fix adds missing methods into generic Firewall class
and in NoopFirewall driver class.

Change-Id: I6402448075ed414434dc007f5c403fc85b6b1456
Closes-Bug: #1369685
Related-Bug: #1365806
(cherry picked from commit 9a6c073656a7e0b1a26b2bca0ba381489d04e322)

neutron/agent/firewall.py

index 7ce1f992098ab2d76686cf00ab15e15df917d238..8ce8e7b16bf51ee93ac0c34e391b4eb551783cbd 100644 (file)
@@ -105,6 +105,14 @@ class FirewallDriver(object):
         finally:
             self.filter_defer_apply_off()
 
+    def update_security_group_members(self, sg_id, ips):
+        """Update group members in a security group."""
+        raise NotImplementedError()
+
+    def update_security_group_rules(self, sg_id, rules):
+        """Update rules in a security group."""
+        raise NotImplementedError()
+
 
 class NoopFirewallDriver(FirewallDriver):
     """Noop Firewall Driver.
@@ -134,3 +142,9 @@ class NoopFirewallDriver(FirewallDriver):
     @property
     def ports(self):
         return {}
+
+    def update_security_group_members(self, sg_id, ips):
+        pass
+
+    def update_security_group_rules(self, sg_id, rules):
+        pass