]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Fixes 'ovs-agent cannot start on Windows because root_helper opt is not found'
authorAdelina Tuvenie <atuvenie@cloudbasesolutions.com>
Tue, 22 Sep 2015 06:51:42 +0000 (23:51 -0700)
committerAdelina Tuvenie <atuvenie@cloudbasesolutions.com>
Thu, 24 Sep 2015 10:18:51 +0000 (03:18 -0700)
Change Ie1224f8a1c17268cd7d1c474ed82fdfb8852eaa8 removed
config.register_root_helper() from ovs_neutron_agent:main, thus the agent
cannot start on Windows since root_helper config option is never
registered.

The fix consists in adding config.register_root_helper in the Windows side
utils.

Closes-Bug: #1497930

Change-Id: I6adc3b869c9564cac3ab99174b8fe47584213e59

neutron/agent/common/utils.py
neutron/agent/linux/utils.py

index 2b50da21704d101182b8f2bf8919cb954c6763a8..a6255709b2467cf0fa0021facba6fb83c9f40ea7 100644 (file)
 
 import os
 
+from oslo_config import cfg
 from oslo_log import log as logging
 from oslo_utils import importutils
 
+from neutron.agent.common import config
 from neutron.i18n import _LE
 
 
@@ -28,6 +30,7 @@ else:
 
 
 LOG = logging.getLogger(__name__)
+config.register_root_helper(cfg.CONF)
 
 
 execute = utils.execute
index b3f7a0bd1ec55f6d5aa6d8f4c2186821d30bd437..83e54ef0ec199b1c3884c244ce7d32bc26764434 100644 (file)
@@ -44,7 +44,6 @@ from neutron import wsgi
 
 
 LOG = logging.getLogger(__name__)
-config.register_root_helper(cfg.CONF)
 
 
 class RootwrapDaemonHelper(object):