]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commitdiff
Enabled add gateway to refrain from checking exit code
authorGary Kotton <gkotton@redhat.com>
Sun, 24 Feb 2013 10:30:08 +0000 (10:30 +0000)
committerGary Kotton <gkotton@redhat.com>
Thu, 28 Feb 2013 15:12:25 +0000 (15:12 +0000)
Fixes bug 1129741

Change-Id: Ibb9a0e1c0f0e5ad610c4f45ae65eb82e25a57b94

quantum/agent/linux/ip_lib.py
quantum/tests/unit/test_linux_ip_lib.py

index 4065b44fffd5054ec70719ab3012f982ff2e8593..31337087e6043cd9c1086d60f488c0688dfbb1b4 100644 (file)
@@ -297,7 +297,7 @@ class IpRouteCommand(IpDeviceCommandBase):
     COMMAND = 'route'
 
     def add_gateway(self, gateway, metric=None):
-        args = ['add', 'default', 'via', gateway]
+        args = ['replace', 'default', 'via', gateway]
         if metric:
             args += ['metric', metric]
         args += ['dev', self.name]
index f4a67dec13238ca136c796a3bc5ecff5a41c553e..cc54ff23cdc24c178ec29ee49b060eac281c4764 100644 (file)
@@ -548,7 +548,7 @@ class TestIpRouteCommand(TestIPCmdBase):
         metric = 100
         self.route_cmd.add_gateway(gateway, metric)
         self._assert_sudo([],
-                          ('add', 'default', 'via', gateway,
+                          ('replace', 'default', 'via', gateway,
                            'metric', metric,
                            'dev', self.parent.name))