Re-enabled hacking checks for H105

Following the upgrade to hacking version 0.10.0 the H105 issues were
ignored. There was a note left in tox.ini to clean up the H105 issues
and to re-enable the check.

Updated tox.ini to re-enable the check of H105 and fixed corresponding
pep8 issues. This way Cinder aligns rows with Nova, Neutron, Glance etc
that have H105 enabled.

Closes-Bug: 1531104
Change-Id: I2da70cbeb838f16ec8479284dda9d7c62566dace

diff --git a/cinder/__init__.py b/cinder/__init__.py
index 2b43c2fafd21c00c2eb94e03c21a6969fa310686..0712b0b63c6e87e12f19ffead2dfcc3364bea97a 100644 (file)
--- a/cinder/__init__.py
+++ b/cinder/__init__.py
@@ -21,10 +21,4 @@
 .. automodule:: cinder
    :platform: Unix
    :synopsis: Infrastructure-as-a-Service Cloud platform.
-.. moduleauthor:: Jesse Andrews <jesse@ansolabs.com>
-.. moduleauthor:: Devin Carlen <devin.carlen@gmail.com>
-.. moduleauthor:: Vishvananda Ishaya <vishvananda@gmail.com>
-.. moduleauthor:: Joshua McKenty <joshua@cognition.ca>
-.. moduleauthor:: Manish Singh <yosh@gimp.org>
-.. moduleauthor:: Andy Smith <andy@anarkystic.com>
 """

diff --git a/cinder/scheduler/__init__.py b/cinder/scheduler/__init__.py
index a8101219914095a1934b89828f393fe99d9c90f8..63a101bf84664ef0b09781bfb27507c9ebf256b6 100644 (file)
--- a/cinder/scheduler/__init__.py
+++ b/cinder/scheduler/__init__.py
@@ -19,7 +19,4 @@
 .. automodule:: cinder.scheduler
    :platform: Unix
    :synopsis: Module that picks a volume node to create a volume.
-.. moduleauthor:: Sandy Walsh <sandy.walsh@rackspace.com>
-.. moduleauthor:: Ed Leafe <ed@leafe.com>
-.. moduleauthor:: Chris Behrens <cbehrens@codestud.com>
 """

diff --git a/cinder/tests/unit/__init__.py b/cinder/tests/unit/__init__.py
index f59fa3d6ed5767cdbed661c9a9e0e5c4fa0407ca..1b5ffcd9aae0d012cdff19a1652ba8115c3ef885 100644 (file)
--- a/cinder/tests/unit/__init__.py
+++ b/cinder/tests/unit/__init__.py
@@ -20,12 +20,6 @@
 
 .. automodule:: cinder.tests.unit
    :platform: Unix
-.. moduleauthor:: Jesse Andrews <jesse@ansolabs.com>
-.. moduleauthor:: Devin Carlen <devin.carlen@gmail.com>
-.. moduleauthor:: Vishvananda Ishaya <vishvananda@gmail.com>
-.. moduleauthor:: Joshua McKenty <joshua@cognition.ca>
-.. moduleauthor:: Manish Singh <yosh@gimp.org>
-.. moduleauthor:: Andy Smith <andy@anarkystic.com>
 """
 
 import eventlet

diff --git a/tox.ini b/tox.ini
index 3a6ac79a1cc70f77a02f976a03e699be9c00bb04..fb71b5829a77d8acd2780125582475582da9478f 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -121,18 +121,7 @@ commands = bandit -c tools/bandit.yaml -r cinder -n 5 -ll
 #
 # E251 unexpected spaces around keyword / parameter equals
 # reason: no improvement in readability
-#
-# Due to the upgrade to hacking 0.9.2 the following checking are
-# ignored on purpose for the moment and should be re-enabled.
-#
-# H405
-# Due to the upgrade to hacking 0.10.0 the following checking are
-# ignored on purpose for the moment and should be cleaned up and re-enabled.
-#
-#  H105  Don't use author tags
-#
-
-ignore = E251,H105
+ignore = E251
 exclude = .git,.venv,.tox,dist,tools,doc,common,*egg,build
 max-complexity=30