]> review.fuel-infra Code Review - openstack-build/heat-build.git/commitdiff
Enable VPC unit tests
authorZane Bitter <zbitter@redhat.com>
Fri, 7 Dec 2012 14:04:15 +0000 (15:04 +0100)
committerZane Bitter <zbitter@redhat.com>
Fri, 7 Dec 2012 14:07:03 +0000 (15:07 +0100)
We don't need quantumclient because the tests use a fake client anyway, so
don't skip the test if it is not installed.

Change-Id: I7cd2447b5a68072d2b43228ab85c53d0124496e5
Signed-off-by: Zane Bitter <zbitter@redhat.com>
heat/tests/test_vpc.py

index 4a5a1dc0d2cb34522f8fc01cbfa70f01007d900b..447a34cb5f1c349721e4ce739fa76e2449019995 100644 (file)
@@ -25,14 +25,6 @@ from heat.common import context
 from heat.common import template_format
 from heat.engine.resources import vpc
 from heat.engine import parser
-from utils import skip_if
-
-try:
-    from quantumclient.v2_0 import client as quantumclient
-except:
-    skip_test = True
-else:
-    skip_test = False
 
 test_template_vpc = '''
 Resources:
@@ -74,10 +66,8 @@ class FakeQuantum():
 @attr(tag=['unit', 'resource'])
 @attr(speed='fast')
 class QuantumTest(unittest.TestCase):
-    @skip_if(skip_test, 'unable to import quantumclient')
     def setUp(self):
         self.m = mox.Mox()
-        self.m.CreateMock(quantumclient)
         self.m.StubOutWithMock(vpc.VPC, 'quantum')
 
     def tearDown(self):
@@ -103,7 +93,6 @@ class QuantumTest(unittest.TestCase):
         self.assertEqual(vpc.VPC.CREATE_COMPLETE, resource.state)
         return resource
 
-    @skip_if(skip_test, 'unable to import quantumclient')
     def test_vpc(self):
         fq = FakeQuantum()
         vpc.VPC.quantum().MultipleTimes().AndReturn(fq)