]> review.fuel-infra Code Review - puppet-modules/puppet-ceilometer.git/commitdiff
Password should be secured
authorZhongShengping <chdzsp@163.com>
Tue, 28 Mar 2017 08:21:30 +0000 (16:21 +0800)
committerZhongShengping <chdzsp@163.com>
Tue, 28 Mar 2017 08:24:10 +0000 (16:24 +0800)
As messaging_urls option contains rabbit_password value, it should
be secured.

Change-Id: I503180280a5558d27c00368e9949aaed52151e79
Closes-Bug: #1676708

manifests/agent/notification.pp
spec/classes/ceilometer_agent_notification_spec.rb

index 50421e8eaf4c1e3a5a8683c73d14053df6ab362d..6e95526e85263dd1b281b6b7d5a491973cd92de1 100644 (file)
@@ -124,6 +124,6 @@ class ceilometer::agent::notification (
     'notification/store_events'             : value => $store_events;
     'notification/disable_non_metric_meters': value => $disable_non_metric_meters;
     'notification/workers'                  : value => $notification_workers;
-    'notification/messaging_urls'           : value => $messaging_urls;
+    'notification/messaging_urls'           : value => $messaging_urls, secret => true;
   }
 }
index d5800a6ab0e262b05263b76626a6da5265e7fd7c..0c0d905dba1e87ebad0e9d1f0f9c3b4b566172dd 100644 (file)
@@ -109,7 +109,7 @@ describe 'ceilometer::agent::notification' do
       it 'configures two messaging urls' do
         is_expected.to contain_ceilometer_config('notification/messaging_urls').with_value(
           ['rabbit://rabbit_user:password@localhost/nova', 'rabbit://rabbit_user:password@localhost/neutron']
-        )
+        ).with_secret(true)
       end
     end