]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commitdiff
Remove unused kill method from Service
authorGorka Eguileor <geguileo@redhat.com>
Tue, 16 Feb 2016 18:09:16 +0000 (19:09 +0100)
committerGorka Eguileor <geguileo@redhat.com>
Tue, 16 Feb 2016 18:20:10 +0000 (19:20 +0100)
In Service class we have a kill method that must have been inherited
from Nova code and that is not currently being used anywhere.

This patch removes this method instead of making it execute on SIGKILL
to preserve current behavior.

Change-Id: I50138d815ac93b171f246f4ecee9d1da1799e00d

cinder/service.py

index 8ab77544cfcc6e540415a7ced6717e015931ded6..6054da6c5ea4c3520964386057d08470ad0debb6 100644 (file)
@@ -263,16 +263,6 @@ class Service(service.Service):
 
         return service_obj
 
-    def kill(self):
-        """Destroy the service object in the datastore."""
-        self.stop()
-        try:
-            service_ref = objects.Service.get_by_id(
-                context.get_admin_context(), self.service_id)
-            service_ref.destroy()
-        except exception.NotFound:
-            LOG.warning(_LW('Service killed that has no database entry'))
-
     def stop(self):
         # Try to shut the connection down, but if we get any sort of
         # errors, go ahead and ignore them.. as we're shutting down anyway