]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Move SolidFire driver from httplib to requests
authorJohn Griffith <john.griffith8@gmail.com>
Fri, 10 Oct 2014 01:22:03 +0000 (19:22 -0600)
committerJohn Griffith <john.griffith8@gmail.com>
Tue, 14 Oct 2014 11:37:13 +0000 (05:37 -0600)
commitfc9242f1e253fde7c2f15f8a5f61c06d4211f111
treef5addb48f7dc8624dfb16515720251c5c25b3c84
parentcbb933743c10dc24fbabe96aa30182e3dc395d85
Move SolidFire driver from httplib to requests

The SolidFire driver has been pretty static for a number of
years now, this change is to move from httplib for API calls
to requests.  There are a number of advantages to this, including
performance, simplicity and ability to add things like ssl support
easily.

In addtion this change removes the confusing looping/retry mechanisms
that were in the issue_api_request method and replaces it with a
retry decorator for the exceptions we're interested in retrying.

Finally, I realize that my unit tests suck!  That will be one of the
follow up items after a bit more clean up in the driver.

Change-Id: Icc4cf601bffddb057f35537f3870c45dd5eb67cc
cinder/exception.py
cinder/tests/test_solidfire.py
cinder/volume/drivers/solidfire.py