]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Remove duplicated debug logging around locking
authorRawlin Peters <rawlin.peters@hp.com>
Mon, 15 Jun 2015 16:57:02 +0000 (10:57 -0600)
committerRawlin Peters <rawlin.peters@hp.com>
Tue, 16 Jun 2015 18:35:20 +0000 (12:35 -0600)
commitfc0c3a83659a86453acd5745a5632729b99cb3de
tree304a64dd4d832ba17cd7b942696a8cc069f6b17c
parent1ab4fc7319010ddd5584451feccf78b704bd09c6
Remove duplicated debug logging around locking

Currently, iptables_manager.py does extra unnecessary logging about lock
acquisition and release. It uses lockutils.lock() which passes
do_log=True by default, which causes lockutils.lock() to do debug
logging about lock acquisition/release. IptablesManager itself also writes
debug log info about lock acquisition and release.

This change will eliminate unnecessary duplicate logging in order to
reduce log noise about locking. This change is also related to
https://github.com/harlowja/fasteners/commit/f88f2fea7fe250b7d26cdcbc84633ccbbc68eeee
which reduces the logging level in the underlying lock implementation
used by oslo.concurrency. That change along with this one will remove
the duplicate debug logging about locking in iptables_manager.py and also in
ipset_manager.py.

Change-Id: If6f4a7101f3783ad83645e28bbb5c577dd403d3b
Closes-Bug: 1464727
neutron/agent/linux/iptables_manager.py