]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Don't pass the port down to the floating ip processing
authorCarl Baldwin <carl.baldwin@hp.com>
Sat, 31 Jan 2015 00:27:52 +0000 (00:27 +0000)
committerCarl Baldwin <carl.baldwin@hp.com>
Sat, 31 Jan 2015 15:45:25 +0000 (15:45 +0000)
commitf97a9cb366f09d33400efb9a172fe462e27aadbd
tree74cd464e61f56fa3c2be3adea1f4577dfcd98308
parent59795ab607579f2c764fecb33f538dae0124671e
Don't pass the port down to the floating ip processing

This is justified by the Law of Demeter.  I ran in to this while
trying to refactor the floating ip processing here [1].  The scope of
that patch can be reduced significantly with this refactor.  Also, it
helps us to decouple the floating ip NAT processing from the details
of the port which is a long-term goal.

[1] https://review.openstack.org/#/c/142863/

Change-Id: I606dfd43977934f1accea60911e10e71c1cbba73
Partially-Implements: bp/restructure-l3-agent
neutron/agent/l3/agent.py
neutron/tests/unit/test_l3_agent.py