]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Replace urllib.unquote with urllib.parse.unquote
authorVipin Balachandran <vbala@vmware.com>
Wed, 26 Aug 2015 10:42:53 +0000 (16:12 +0530)
committerVipin Balachandran <vbala@vmware.com>
Wed, 26 Aug 2015 10:42:53 +0000 (16:12 +0530)
commitf90bcd4964d646bdad67a2cb012bd7eb499f85f9
treed4fe7e5eba8fc3ec02b5ebd43f3cf02b71a01745
parentea4be60e8584c715e2c3119000e94074da310970
Replace urllib.unquote with urllib.parse.unquote

This patch replaces urllib.unquote with urllib.parse.unquote
in the vmdk driver.

Commit d08c7ffe52e3ee211e425c363200998704726e58 replaced
urllib and urllib2 with six.moves.urllib and changed urllib.
unquote to urllib.parse.unquote but missed one call site
in the vmdk driver since the code which introduced it was
under review at the same time. Due to this, if we set an
optional parameter 'vmware_cluster_name', the driver init
will fail with AttributeError.

This patch also adds a unit test which would have caught
this error during gate check.

Change-Id: I310456f5d677c6e100a91efc6228c533cb5bf208
Closes-Bug: #1488916
cinder/tests/unit/test_vmware_volumeops.py
cinder/volume/drivers/vmware/volumeops.py