]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commit
(GH-129) Replace errant return in autoreq block
authorDan Carley <dan.carley@gmail.com>
Sun, 3 Mar 2013 14:32:38 +0000 (14:32 +0000)
committerDan Carley <dan.carley@gmail.com>
Sun, 3 Mar 2013 14:32:38 +0000 (14:32 +0000)
commitf6bc77e73e137ca1ebb70e8d62461f9105487864
tree2f8631e94e40c7a2c9b910c5ab745894692c9241
parent6ae5794a5efcf1c026d6d021c1a93518b1dd67b7
(GH-129) Replace errant return in autoreq block

It's not valid to use `return` within a block. We could use `next []`,
however it's probably better form to just always return the array, whether
it's populated or not. This will stop the error:

    err: Got an uncaught exception of type LocalJumpError: unexpected return

When one of the listed providers isn't selected. Which is suitable, because
this autorequire won't be suitable to any other future providers anyway.
lib/puppet/type/firewall.rb