]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
func: Don't use private method of AsyncProcess
authorJakub Libosvar <libosvar@redhat.com>
Mon, 14 Sep 2015 14:54:34 +0000 (14:54 +0000)
committerJakub Libosvar <libosvar@redhat.com>
Tue, 15 Sep 2015 08:53:57 +0000 (08:53 +0000)
commitf4a76a7a26c0902d61f4fe61091e7fe556923592
tree6af34da40a27445d11c943bc6244902f338a0b85
parent710ab239e404a3ef138b7dd796d028ad375060e8
func: Don't use private method of AsyncProcess

In functional test we simulate crash of AsyncProcess by calling
_kill_process(). This method is a private method and such usage
introduced a race where process was respawned prior to calling wait() of
killed process, leading to infinite wait on newly spawned process.

This patch adds manual send of kill and then active waiting for process
to be respawned, similarly like done with recent keepalived patch [1].

[1] https://review.openstack.org/#/c/222460/7/neutron/tests/functional/agent/linux/test_keepalived.py

Closes-Bug: #1477860
Change-Id: I1c91393304d65a0695311416ecc5b64fd549b192
neutron/tests/functional/agent/linux/test_async_process.py